Set up GitHub Actions #837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcressey
reviewed
Mar 10, 2020
Comment on lines
+7
to
+12
| runs-on: [self-hosted, linux, x64] | ||
| steps: | ||
| - uses: actions/checkout@v1 | ||
| - run: cargo install --version 0.28.0 cargo-make | ||
| - run: cargo install --version 0.6.6 cargo-deny --no-default-features | ||
| - run: cargo make |
There was a problem hiding this comment.
If we wanted to extend this to also build arm64, what would that look like? Two separate actions, Build x86_64 and Build arm64?
We could do it here with cargo make clean ; cargo make -e BUILDSYS_ARCH=aarch64 but that would double the time it takes and ideally we'd run them in parallel.
There was a problem hiding this comment.
Yep!
I think we might want to eventually do:
- Build x86_64
- Build aarch64
- Unit tests
bcressey
approved these changes
Mar 10, 2020
|
🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
n/a
Description of changes:
Adds a workflow for testing builds on pull requests using our hosted runners.
Testing done:
This PR tests itself :)
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.